Hi Marek,
On Fri, 23 Aug 2019 23:26:02 +0200, Marek Behún <[email protected]> wrote:
> -int mv88e6xxx_port_hidden_write(struct mv88e6xxx_chip *chip, int port, int
> reg,
> - u16 val);
> +int mv88e6xxx_port_hidden_write(struct mv88e6xxx_chip *chip, int block, int
> port,
> + int reg, u16 val);
> int mv88e6xxx_port_hidden_wait(struct mv88e6xxx_chip *chip);
> -int mv88e6xxx_port_hidden_read(struct mv88e6xxx_chip *chip, int port, int
> reg,
> - u16 *val);
> +int mv88e6xxx_port_hidden_read(struct mv88e6xxx_chip *chip, int block, int
> port,
> + int reg, u16 *val);
There's something I'm having trouble to follow here. This series keeps
adding and modifying its own code. Wouldn't it be simpler for everyone
if you directly implement the final mv88e6xxx_port_hidden_{read,write}
functions taking this block argument, and update the code to switch to it?
While at it, I don't really mind the "hidden" name, but is this the name
used in the documentation, if any?
Thank for you patience,
Vivien
