Hi Marek,
On Fri, 23 Aug 2019 23:25:57 +0200, Marek Behún <[email protected]> wrote:
> /* Offset 0x1a: Magic undocumented errata register */
/* Offset 0x1A: Reserved */
(nitpicking here, for consistency this other definitions as shown in docs.)
> -#define PORT_RESERVED_1A 0x1a
> -#define PORT_RESERVED_1A_BUSY BIT(15)
> -#define PORT_RESERVED_1A_WRITE BIT(14)
> -#define PORT_RESERVED_1A_READ 0
> -#define PORT_RESERVED_1A_PORT_SHIFT 5
> -#define PORT_RESERVED_1A_BLOCK (0xf << 10)
> -#define PORT_RESERVED_1A_CTRL_PORT 4
> -#define PORT_RESERVED_1A_DATA_PORT 5
> +#define MV88E6XXX_PORT_RESERVED_1A 0x1a
> +#define MV88E6XXX_PORT_RESERVED_1A_BUSY 0x8000
> +#define MV88E6XXX_PORT_RESERVED_1A_WRITE 0x4000
> +#define MV88E6XXX_PORT_RESERVED_1A_READ 0x0000
> +#define MV88E6XXX_PORT_RESERVED_1A_PORT_SHIFT 5
> +#define MV88E6XXX_PORT_RESERVED_1A_BLOCK 0x3c00
> +#define MV88E6XXX_PORT_RESERVED_1A_CTRL_PORT 0x04
> +#define MV88E6XXX_PORT_RESERVED_1A_DATA_PORT 0x05
You are already using these macros in the previous patch. I guess you meant
to introduce this patch before. But since you are moving and renaming the
same code without functional changes, you may squash them together.
Thanks,
Vivien
