Re: [PATCH net-next v2 4/9] net: dsa: mv88e6xxx: create chip->info->ops->serdes_get_lane method

[Vivien Didelot]

Hi Marek,

On Fri, 23 Aug 2019 23:25:58 +0200, Marek Behún <marek.be...@nic.cz> wrote:
> +     /* SERDES lane mapping */
> +     int (*serdes_get_lane)(struct mv88e6xxx_chip *chip, int port);

I would prefer to keep the return code strictly for error checking as commonly
used in the driver:

    int (*serdes_get_lane)(struct mv88e6xxx_chip *chip, int port, int *lane);

Also the "lane" seems to be an address, so maybe u8 or u16 if more appropriate?


Thanks,

        Vivien