Hi Catherine, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Catherine-Sullivan/Add-gve-driver/20190629-070444 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/net/ethernet/google/gve/gve_ethtool.c:147:6: sparse: sparse: symbol >> 'gve_get_channels' was not declared. Should it be static? >> drivers/net/ethernet/google/gve/gve_ethtool.c:161:5: sparse: sparse: symbol >> 'gve_set_channels' was not declared. Should it be static? >> drivers/net/ethernet/google/gve/gve_ethtool.c:191:6: sparse: sparse: symbol >> 'gve_get_ringparam' was not declared. Should it be static? >> drivers/net/ethernet/google/gve/gve_ethtool.c:202:5: sparse: sparse: symbol >> 'gve_user_reset' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
