Hi Catherine, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Catherine-Sullivan/Add-gve-driver/20190629-070444 config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): In file included from drivers/net/ethernet/google/gve/gve_main.c:16:0: drivers/net/ethernet/google/gve/gve_adminq.h: In function 'gve_assert_size_gve_adminq_create_rx_queue': >> drivers/net/ethernet/google/gve/gve_adminq.h:134:469: error: call to >> '__compiletime_assert_134' declared with attribute error: BUILD_BUG_ON >> failed: sizeof(struct gve_adminq_create_rx_queue) != (48) GVE_ASSERT_SIZE(struct, gve_adminq_create_rx_queue, 48); ^ In file included from drivers/net/ethernet/google/gve/gve_main.c:16:0: drivers/net/ethernet/google/gve/gve_adminq.h: In function 'gve_assert_size_gve_adminq_set_driver_parameter': drivers/net/ethernet/google/gve/gve_adminq.h:171:489: error: call to '__compiletime_assert_171' declared with attribute error: BUILD_BUG_ON failed: sizeof(struct gve_adminq_set_driver_parameter) != (16) GVE_ASSERT_SIZE(struct, gve_adminq_set_driver_parameter, 16); ^ vim +/__compiletime_assert_134 +134 drivers/net/ethernet/google/gve/gve_adminq.h 133 > 134 GVE_ASSERT_SIZE(struct, gve_adminq_create_rx_queue, 48); 135 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
