Hi Catherine, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Catherine-Sullivan/Add-gve-driver/20190629-070444 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/google/gve/gve_main.c:23:12: sparse: sparse: symbol 'gve_version_str' was not declared. Should it be static? >> drivers/net/ethernet/google/gve/gve_main.c:24:12: sparse: sparse: symbol >> 'gve_version_prefix' was not declared. Should it be static? >> drivers/net/ethernet/google/gve/gve_main.c:352:25: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_main.c:352:25: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_main.c:352:25: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_main.c:352:25: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_main.c:352:25: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_main.c:352:25: sparse: sparse: cast to >> restricted __be32 drivers/net/ethernet/google/gve/gve_main.c:353:25: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/google/gve/gve_main.c:353:25: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/google/gve/gve_main.c:353:25: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/google/gve/gve_main.c:353:25: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/google/gve/gve_main.c:353:25: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/google/gve/gve_main.c:353:25: sparse: sparse: cast to restricted __be32 -- >> drivers/net/ethernet/google/gve/gve_adminq.c:28:16: sparse: sparse: >> incorrect type in argument 1 (different base types) @@ expected unsigned >> int val @@ got restricted __be3unsigned int val @@ >> drivers/net/ethernet/google/gve/gve_adminq.c:28:16: sparse: expected >> unsigned int val >> drivers/net/ethernet/google/gve/gve_adminq.c:28:16: sparse: got >> restricted __be32 [usertype] drivers/net/ethernet/google/gve/gve_adminq.c:68:16: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int val @@ got restricted __be3unsigned int val @@ drivers/net/ethernet/google/gve/gve_adminq.c:68:16: sparse: expected unsigned int val drivers/net/ethernet/google/gve/gve_adminq.c:68:16: sparse: got restricted __be32 [usertype] >> drivers/net/ethernet/google/gve/gve_adminq.c:77:21: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_adminq.c:77:21: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_adminq.c:77:21: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_adminq.c:77:21: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_adminq.c:77:21: sparse: sparse: cast to >> restricted __be32 >> drivers/net/ethernet/google/gve/gve_adminq.c:77:21: sparse: sparse: cast to >> restricted __be32 Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
