Hi Samih! Please don't top post on Linux kernel mailing lists.
On Thu, 6 Jun 2019 10:23:40 +0000, Jubran, Samih wrote: > As of today there are no flags exposed by ENA NIC device, however, we > are planning to use them in the near future. We want to provide > customers with extra methods to identify (and differentiate) multiple > network interfaces that can be attached to a single VM. Currently, > customers can identify a specific network interface (ENI) only by MAC > address, and later look up this MAC among other multiple ENIs that > they have. In some cases it might not be convenient. Using these > flags will let us inform the customer about ENI`s specific > properties. Oh no :( You're using private _feature_ flags as labels or tags. > It's not finalized, but tentatively it can look like this: > primary-eni: on /* Differentiate between primary and secondary ENIs */ Did you consider using phys_port_name for this use case? If the intent is to have those interfaces bonded, even better would be to extend the net_failover module or work on user space ABI for VM failover. That might be a bigger effort, though. > has-associated-efa: on /* Will specify ENA device has another associated EFA > device */ IDK how your ENA/EFA thing works, but sounds like something that should be solved in the device model.
