On Mon, 3 Jun 2019 17:43:18 +0300, same...@amazon.com wrote: > * net: ena: ethtool: add extra properties retrieval via get_priv_flags (2/11): > * replaced snprintf with strlcpy > * dropped confusing error message > * added more details to the commit message
I asked you to clearly state that you are using the blindly passing this info from the FW to user space. Stating that you "retrieve" it is misleading. IMHO it's a dangerous precedent, you're extending kernel's uAPI down to the proprietary FW of the device. Now we have no idea what the flags are, so we can't refactor and create common APIs among drivers, or even use the same names. We have no idea what you're exposing.
