Re: [iproute2] regression in ss output

[Humberto Alves]

Yes, just get rid of this 'if statement'.



On 10/16/2017 11:33 AM, Phil Sutter wrote:

in6addr_any should be represented as '::', not '*'. Otherwise it's impossible to distinguish IPv4 listening addresses from IPv6. Thank you :)

Hi,

On Fri, Oct 13, 2017 at 09:57:37AM +0000, Humberto Alves wrote:

Hi! With the last iproute2 release, ss command output does not
differentiate between any-address IPv4 sockets from the IPv6 ones.
I don't know if this is an expected behaviour, but the old output looks
more useful. Below I pasted the difference between the old behaviour and
the new one.

Although the change is certainly intentional (it was introduced by
Stephen Hemminger as a side effect of aba9c23a6e1cb ("ss: enclose IPv6
address in brackets"), I second reverting to the old display of
in6addr_any as '::'.

I am happy to send a patch if you want. Thanks

It should be enough to just getting rid of the

| if (!memcmp(a->data, &in6addr_any, sizeof(in6addr_any))) {

case in inet_addr_print(). The else-case which calls format_host()
should deal with in6addr_any just fine. This way the address also gets
enclosed in brackets which helps separating it from the ':port' part.

Cheers, Phil

smime.p7s
Description: S/MIME Cryptographic Signature