On Tue, 18 Apr 2006 12:28:48 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote:
> Hi Stephen: > > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > This fixes http://bugzilla.kernel.org/show_bug.cgi?id=6388 > > The bug is caused by ip_route_input dereferencing skb->nh.protocol of > > the dummy skb passed dow from inet_rtm_getroute (Thanks Thomas for seeing > > it). It only happens if the route requested is for a multicast IP > > address. > > Good catch. > > > - skb->mac.raw = skb->data; > > + skb->mac.raw = skb->nh.raw = skb->data; > > This should fix it. > > > + /* Bugfix: need to give ip_route_input enough of an IP header to > > not gag. */ > > + skb->nh.iph->protocol = IPPROTO_ICMP; > > Do we really need this? After all we can get completely bogus values > coming in through the network too. Not really, just that ip_check_mc looks at the proto for !IGMP. And maybe some tool like coverity or sparse would be smart enough to look for uninitialized data usage. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
