From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 18 Apr 2006 16:54:48 +1000
> Looking at this again, the root of this problem is the IGMPv3 > patch which started using the skb->nh.iph->protocol as a key. > > So what we really should do is make the protocol an explicit parameter > to the ip_route_input function. This will make it clear to all the > users which include some pretty weird cases that the protocol is needed. > > In fact I'm unsure as to whether all the other users of ip_route_input > is safe as it is regarding the protocol. There are other areas of the packet which are interpreted in various ways. For example, the martian source handling will dump the MAC directly from skb->mac.raw into the kernel logs. The output path is so much cleaner, because things like the protocol are filled out in the struct flowi so there is no need to be parsing the SKB in any way. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
