Hello! > There is also the ARP code which passes an ARP packet through that > would get dereferenced as an IP packet. Granted this shouldn't crash > because nh is set properly.
And points to something which is not an IP header. So, iph->protocol is something funny. :-) It is plain luck that this never happens, ARP packets with multicast addresses are filtered out. Mess, I agree. > But we really should make up our mind as to whether the routing key > comes from the arguments to ip_route_input (src/dst/...) or the skb. > > Using both is just asking for trouble. Well, both sets are present only for use the same function in ARP. So, arguments. Actually, skb can be preserved, but it should not be used for anything but debugging or for hints, when we should not create cache entry. BTW, I cannot figure out what ip_check_mc() tries to do with protocol (which is __u16 by some reason). If it creates cache entry, protocol is not checked. Funny. Alexey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
