John W. Linville wrote:
> I wonder how many files include ethtool.h w/o including
> netdevice.h...? 
> 
> Anyway, why not just include netdevice.h at the top of ethtool.h?
> Lots of other header files do it e.g. ethdevice.h, inetdevice.h,
> if_arp.h, if_bridge.h, if_vlan.h, ip.h, neighbour.h, sock.h, and
> many others...
> 
> I've known coders who find including headers from other headers
> distasteful, but I find it far less distasteful than replicating
> definitions. :-)
> 
> John

Okay, I'll add the include to the ethtool.h patch and get rid of the
#def.

Thanks for your help,

Jon Wetzel
Dell Intern
Linux Development Lab
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to