First off, I think making the get_perm_addr function into an ethtool op is a fine idea. Also, thanks for catching the unmatched bracket; once again I have been humbled by the "errant backspace".
On Wed, Jul 27, 2005 at 09:56:05PM -0400, John W. Linville wrote: > Drivers would still have the option to override if they so choose. > But, since the ETH_MAX_ADDR_LEN definition is actually 32 (which > matches MAX_ADDR_LEN anyway) then it is a bit of a moot point... :-) > > Jon, you should probably add a patch (or redo you current patch) > and use MAX_ADDR_LEN instead of adding the new ETH_MAX_ADDR_LEN... I wanted to do this initially, but MAX_ADDR_LEN is declared in net device, and ethtool.h doesn't include it. So, instead of creating a new dependency, I added a new constant. Let me know what you think, and I'll write up a new patch. Jon Wetzel Dell Intern Linux Development Lab - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
