On Wed, Jul 27, 2005 at 06:45:18PM -0700, cramerj wrote: > Stupid question: Can we assume ethtool will only be used for networking > devices with a 6-byte hardware address? I presume not...?
> If not, then the driver-specific approach would give the flexibility of > copying anything up to MAX_ADDR_LEN. > > Perhaps increasing the count to MAX_ADDR_LEN is the way to go?? Drivers would still have the option to override if they so choose. But, since the ETH_MAX_ADDR_LEN definition is actually 32 (which matches MAX_ADDR_LEN anyway) then it is a bit of a moot point... :-) Jon, you should probably add a patch (or redo you current patch) and use MAX_ADDR_LEN instead of adding the new ETH_MAX_ADDR_LEN... John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
