On Thu, 2 Apr 2026 13:19:33 GMT, Daniel Fuchs <[email protected]> wrote:

>> May I get a review for this change that converts `java/net/DatagramSocket` 
>> TestNG tests to use JUnit.
>> 
>> Some of these tests now take advantage from the fact that Closeable 
>> arguments passed to a ParameterizedTest are automatically closed by JUnit.
>
> Daniel Fuchs has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into junit-ds-8381359
>  - Review feedback
>  - Apply suggestions from code review
>    
>    Co-authored-by: Marcono1234 <[email protected]>
>  - Apply suggestion from @Marcono1234
>    
>    Co-authored-by: Marcono1234 <[email protected]>
>  - 8381359: Refactor java/net/DatagramSocket TestNG tests to use JUnit

I merged in the master branch and resolved some conflicts in 
SendReceiveMaxSize, I would appreciate a formal Review of this PR. I will give 
it a new round of tier2 before integrating.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30502#issuecomment-4205363237

Reply via email to