On Fri, 3 Apr 2026 16:46:33 GMT, Alan Bateman <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> test/jdk/java/net/Socket/ConnectionReset.java line 174:
>
>> 172: assertTrue(false);
>> 173: } catch (IOException ioe) {
>> 174: // expected
>
> If you want to go further then this could be changed to use assertThrows.
Done - here and elsewhere in the test
> test/jdk/java/net/Socket/ConnectionReset.java line 182:
>
>> 180: assertTrue(false);
>> 181: } catch (IOException ioe) {
>> 182: System.out.format("available => %s (expected)%n", ioe);
>
> For this test I think it is important that trace messages are inlined, so
> need to go to System.err.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3045382050
PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3045383120
