On Fri, 3 Apr 2026 12:26:46 GMT, Michael McMahon <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed two mistakes > > test/jdk/java/net/SocketImpl/TestDefaultBehavior.java line 28: > >> 26: * @bug 8224477 >> 27: * @summary Basic test for java.net.SocketImpl default behavior >> 28: * @run junit TestDefaultBehavior > > I notice you didn't change this to use $(test.main.classes}. Was this > overlooked? > > Also, just wondering what was the reason for the change elsewhere? Oh - thanks. There are two files by that name. I probably overlooked the other. Changed now. > Also, just wondering what was the reason for the change elsewhere? Feedback from previous reviews. If you're changing the `@run` line ... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3032803342
