On Tue, 7 Apr 2026 14:36:20 GMT, Daniel Fuchs <[email protected]> wrote:
>> Some more TestNG -> JUnit conversion for java/net tests.
>> This change converts tests under:
>>
>> test/jdk/java/net/DatagramSocketImpl/
>> test/jdk/java/net/MulticastSocket/
>> test/jdk/java/net/Socket/
>> test/jdk/java/net/SocketImpl/
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> More review feedback on SocketImplCombinations.java
test/jdk/java/net/Socket/ConnectionReset.java line 94:
> 92: System.err.println("read => EOF");
> 93: assertNotEquals(-1, bytesRead);
> 94: }
If you are changing this part of the test then it would be simpler to just
`assertNotEquals(-1, bytesRead, "EOF not expected")`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3045908315
