On Wed, 18 Mar 2026 13:22:10 GMT, Volkan Yazici <[email protected]> wrote:

> The new comment block LGTM.

Thanks!

> IMHO, the point of this particular comment block is to warn the next person 
> touching to this piece of code that fast paths and branch-free concatenations 
> are there for a reason, don't update it without checking performance figures. 
> The details of how this all works today (`OptimizedStringConcat`, etc.) will 
> likely to not apply in some near future anyway.

Right. So maybe a shorter note would serve this purpose just as good.  
Something like:


// The fast paths and branch-free concatenations in this method are here for
// a reason and should not be updated without checking performance figures.


WDYT?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30151#issuecomment-4082595821

Reply via email to