On Fri, 13 Mar 2026 11:58:17 GMT, Volkan Yazici <[email protected]> wrote:

>> Eirik Bjørsnøs has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Use explicit booleans instead of var for optionality locals
>
> Tier 1-2 is clear on d8de37ef43e.

Thanks a lot @vy for your review and testing!

The reason I'm holding off on integrating here is that parts of the performance 
wins here rely on fragilities of OptimizedStringConcat. 

I  think there are performance wins here which would also be useful in a world 
where  OptimizedStringConcat was less fragile.  I'm just bit uncomfortable with 
the code comment since I don't think I fully understand what's going on. A 
wrong or misleading comment may be worse than none at all.

I've inquired on hotspot-compiler-dev, let's see if that leads to anything.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30151#issuecomment-4077500172

Reply via email to