On Fri, 13 Mar 2026 11:58:17 GMT, Volkan Yazici <[email protected]> wrote:

>> Eirik Bjørsnøs has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Use explicit booleans instead of var for optionality locals
>
> Tier 1-2 is clear on d8de37ef43e.

> Thanks a lot @vy for your review and testing!
> 
> The reason I'm holding off on integrating here is that parts of the 
> performance wins here rely on fragilities of OptimizedStringConcat.

Okay, I have come to think OptimizedStringConcat is what it is. So I  expanded 
the code comment a bit into what I think is more explicit and accurate, without 
diving into details too much. 

It's a difficult excercise to write to an audience so separated by time and 
contextual understanding. 

@vy Let me know what you think of 6bf512a.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30151#issuecomment-4082142188

Reply via email to