Eero Pajarre wrote:
>
> Keith Whitwell wrote:
> >
> >
> > That's probably not correct. The code looks odd, but basically what it is saying
> > is that if we are lighting in object space and not using Rescale, then we have to
> > introduce the effects of the scale that the normals would have picked up if they
> > had really been moved to eye space...
> >
> > I think you are in the right track, but that isn't quite the right fix.
> >
>
> 1) The fix did help, although that doesn't prove it to be correct
> 2) the NeedEyeCoords branch above has similar code
> 3) The original condition "Don't rescale and rescale factor != 1.0
> was quite odd...
It's odd for the reasons I described - because you have to insert a scaling
factor which *would* have been applied had you moved to eye coordinates. I'm not
suprised the fix helped - it probably means there is a missing case in there.
Keith
_______________________________________________
Mesa-dev maillist - [EMAIL PROTECTED]
http://lists.mesa3d.org/mailman/listinfo/mesa-dev
