Connor Abbott <[email protected]> writes: > Hi Eric, > > A general suggestion: > > I think that we should rename these functions to "nir_op_create()" so > that we can make a more specific "nir_op()" function that takes and > returns a nir_ssa_def *, so that we can do stuff like: > > nir_builder *b = ... > > nir_ssa_def *new_index = nir_iadd(b, nir_imul(b, old_index, > nir_const_int(b, stride)), nir_const_int(b, offset)); > > Similar to how the old IR builder works. Granted, it would only work > with SSA, but most of the stuff we do only involves SSA until the very > end anyways...
Yeah, when I first wrote this I wasn't doing SSA, but definitely worth trying a rewrite that way.
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
