nikic wrote: > > I don't know if I understand what you're going for in this patch. How is > > this an improvement over just keeping REQUIRES: shell? The REQUIRES: bit > > is what's going to stop the test from running in the wrong environment. > > That seems like the right tradeoff. > > If we don't get rid of all the `REQUIRES: shell` checks and we want to turn > on the internal shell by default, we end up losing test coverage here. Unless > we explicitly have a buildbot running tests with the exteral shell, which > seems like a bit of a waste.
Somewhat off-topic for this PR, but why can't `REQUIRES: shell` force use of shell even if internal shell is the default? Then we don't lose test coverage and don't block this on migration of the long-tail of tests. https://github.com/llvm/llvm-project/pull/157232 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
