boomanaiden154 wrote: > I don't know if I understand what you're going for in this patch. How is this > an improvement over just keeping REQUIRES: shell? The REQUIRES: bit is > what's going to stop the test from running in the wrong environment. That > seems like the right tradeoff.
If we don't get rid of all the `REQUIRES: shell` checks and we want to turn on the internal shell by default, we end up losing test coverage here. Unless we explicitly have a buildbot running tests with the exteral shell, which seems like a bit of a waste. Let me try rewriting this one in Python though, because I think that will capture the semantics of the test better and also avoid the use of bash. https://github.com/llvm/llvm-project/pull/157232 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
