clayborg wrote:

That being said, if there is something we can do to this PR to make it easy for 
you (Pavel) to implement this feature, we can make those changes. Like I think 
it would be fair to change all `PeekMemory/DoPeekMemory` over a virtual 
`ReadMemory/DoReadMemory` that returns a `DataExtractor` as this can easily 
take place of the `ArrayRef<uint8_t>` values that are returned.

This:
```
  virtual llvm::ArrayRef<uint8_t> PeekMemory(lldb::addr_t low, lldb::addr_t 
high);
```
Could become:
```
  virtual DataExtractor ReadMemory(lldb::addr_t low, lldb::addr_t high);
```
And we can adjust all users of `PeekMemory` and `DoPeakMemory` to use the the 
above functions?


https://github.com/llvm/llvm-project/pull/102536
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to