https://github.com/clayborg commented:

I vote to leave this PR as is because `VMRangeToFileOffset` is a list of 
VMRanges that map to file offsets and this list combines entries with 
consecutive address ranges whose data is consecutive in the core file. And 
`VMRangeToPermissions` does not break things up. So not sure how we could use 
memory regions with this. It would also make the patch really large to have 
`Process::ReadMemory` return a `DataExtractor` and change all code over to 
using that. I do like this idea and think that we should work on a patch that 
can do this because `PeekMemory` could easily set the data pointers within a 
`DataExtractor` without copying the data. 

https://github.com/llvm/llvm-project/pull/102536
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to