jingham added a comment.

I wonder about this one.  In every instance where the API is used, its result 
is turned into a ConstString first.  That's because this variable name lives in 
the same slot as normal variable names, which come from the debug information 
and so tend to be in the ConstString pool for better reasons.  Do you project 
being able to get rid of that latter requirement?  If not, it seems a bit odd 
to go to the trouble to avoid this value starting life as a ConstString when 
the first thing everybody does with it is to turn it into a ConstString.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152324/new/

https://reviews.llvm.org/D152324

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits]... Alex Langford via Phabricator via lldb-commits
    • [Lldb-com... Adrian Prantl via Phabricator via lldb-commits
    • [Lldb-com... Alex Langford via Phabricator via lldb-commits
    • [Lldb-com... Jonas Devlieghere via Phabricator via lldb-commits
    • [Lldb-com... Felipe de Azevedo Piovezan via Phabricator via lldb-commits
    • [Lldb-com... Jim Ingham via Phabricator via lldb-commits
    • [Lldb-com... Alex Langford via Phabricator via lldb-commits

Reply via email to