dblaikie added a comment.

Perhaps the change to use accessors could be removed, now that you've used it 
to find all the places that needed to be fixed up? (like just using it for 
cleanup/temporary purposes, without needing to commit that API change?)



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:115
+    private:
+      uint64_t Fields[2];
+
----------------
How come this became an array? Rather than keeping it as two named fields?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139379/new/

https://reviews.llvm.org/D139379

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to