seehearfeel added inline comments.
================
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.h:24
+
+class NativeRegisterContextLinux_loongarch64 : public
NativeRegisterContextLinux {
+public:
----------------
SixWeining wrote:
> Pls limit the columns count to 80 which can be done by `clang-format`. See:
> https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
OK, will do it and then update.
================
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.h:9
+
+#if defined(__loongarch__) && __loongarch_grlen == 64
+
----------------
SixWeining wrote:
> Seems `#if __loongarch_grlen == 64` is enough? But I'm fine with both.
Let us leave it as it is like riscv does, thank you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136578/new/
https://reviews.llvm.org/D136578
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
