tschuett added inline comments.
================ Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.cpp:43 +uint32_t RegisterInfoPOSIX_loongarch64::GetRegisterCount() const { + return 0; +} ---------------- Stupid question: why is the register count 0? ================ Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26 +public: + enum { GPRegSet = 0, FPRegSet }; + ---------------- Firstly, I prefer `ènum class`. Second, it is unused? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136578/new/ https://reviews.llvm.org/D136578 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits