SixWeining accepted this revision.
SixWeining added a comment.
LGTM for LoongArch related changes.
================
Comment at:
lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26
+public:
+ struct GPR {
+ uint64_t gpr[32];
----------------
xry111 wrote:
> SixWeining wrote:
> > Why is this structure and below `FPR` defined like this? Do you intent to
> > keep the layout same as some structures of Linux? If yes, is it necessary?
> It seems necessary because lldb invokes `ptrace` system call which directly
> stores into the pointer returned by `GetGPRBuffer`.
Make sense. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136578/new/
https://reviews.llvm.org/D136578
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
