fixathon added a comment.
Herald added a project: All.
Added some follow up comments
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561
+ default:
+ LLVM_FALLTHROUGH;
+ case ArchSpec::eCore_arm_arm64: {
----------------
This will default to the ArchSpec::eCore_arm_arm64 case if no matching ArchSpec
is specified. Double-checking if this by intent.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640
+ }
+ return {};
+}
----------------
Could we delete this unreachable return statement? It's tripping up static
code checkers since all possible branches already have a return.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113155/new/
https://reviews.llvm.org/D113155
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
