[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

It would be good to have a test for the ObjectFileELF part at least. I'm 
thinking of something similar to what we have in 
`test/Shell/ObjectFile/PECOFF/symbol.yaml` for COFF...



================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2218
 
     bool is_global = symbol.getBinding() == STB_GLOBAL;
     uint32_t flags = symbol.st_other << 8 | symbol.st_info | additional_flags;
----------------
I think it'd be more natural to do the STB_WEAK check here. Maybe something 
like:
```
switch (symbol.getBinding()) {
  case STB_GLOBAL:
    is_external = true;
    break;
   case STB_WEAK:
    is_weak = true;
    is_external = true;
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87868/new/

https://reviews.llvm.org/D87868

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits