labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Sorry about the breakage.
================
Comment at: lldb/cmake/modules/FindPythonAndSwig.cmake:51
"${SWIG_VERSION}" VERSION_LESS "4.0" AND WIN32 AND (
- ${MULTI_CONFIG} OR (${uppercase_CMAKE_BUILD_TYPE} STREQUAL "DEBUG")))
+ ${MULTI_CONFIG} OR (uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")))
# Technically this can happen with non-Windows builds too, but we are not
----------------
Maybe add quotes here instead of dropping the `${}`. I'm not really sure which
one is more idiomatic, but that's what I did for the other variables
(SWIG_VERSION, etc.) -- it seems I just forgot about this one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89807/new/
https://reviews.llvm.org/D89807
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
