labath added a comment.

This seems like a good idea, but I really don't like the AllPlugins name, when 
it does not, in fact, initialize all plugins. I'm not really sure what to name 
it because criterion is pretty complex (though reasonable).

Another way to achieve something like this would be to create something like 
`Plugins/ObjectFile/AllPlugins.h` (or sth), which would initialize all object 
file plugins (and similar for other plugin kinds). Then the inividual "system 
initializers" would call these. That would still leave us with a bit of 
duplication between lldb-test and liblldb, but this could be justifiable as 
liblldb actually fully initializes some additional plugin kinds while lldb-test 
does not. (And we add new plugins much more often than we add a completely 
different plugin kinds).



================
Comment at: lldb/tools/lldb-test/CMakeLists.txt:20
     lldbUtility
     ${LLDB_ALL_PLUGINS}
+    lldbInitializationAllPlugins
----------------
I guess you don't need this then...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73018/new/

https://reviews.llvm.org/D73018



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to