labath marked an inline comment as done.
labath added inline comments.

================
Comment at: lldb/test/Shell/Watchpoint/netbsd-nouserdbregs.test:5
+# REQUIRES: native && system-netbsd && (target-x86 || target-x86_64) && 
!dbregs-set
+# RUN: %clang %p/Inputs/thread-dbreg.c -pthread -g -o %t.out
+# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error 
false' -s %s %t.out 2>&1 | FileCheck %s
----------------
mgorny wrote:
> labath wrote:
> > mgorny wrote:
> > > Note to self: try `%clang_host` as suggested in D70050.
> > So, did you try it?
> Sorry, I've forgotten about it. Done now. I presume I don't need `native` in 
> REQUIRES now.
> 
> Will address remaining comments soonish.
`system-netbsd` should be enough, but we never really bothered to add  "native" 
 even before we had %clang_host. I'm pretty sure a _lot_ of things would blow 
up if you configured your build so that the default clang target is not the 
host system.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70023/new/

https://reviews.llvm.org/D70023



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to