mgorny planned changes to this revision. mgorny marked an inline comment as done. mgorny added inline comments. Herald added a subscriber: dexonsmith.
================ Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:281 + NativeThreadNetBSD& t = AddThread(pst.pe_lwp); + t.CopyWatchpointsFrom( + static_cast<NativeThreadNetBSD &>(*GetCurrentThread())); ---------------- Note to self: need to add error handling here. ================ Comment at: lldb/test/Shell/Watchpoint/netbsd-nouserdbregs.test:5 +# REQUIRES: native && system-netbsd && (target-x86 || target-x86_64) && !dbregs-set +# RUN: %clang %p/Inputs/thread-dbreg.c -pthread -g -o %t.out +# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error false' -s %s %t.out 2>&1 | FileCheck %s ---------------- Note to self: try `%clang_host` as suggested in D70050. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70023/new/ https://reviews.llvm.org/D70023 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
