mgorny added inline comments.
================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp:254-255
+ .CopyHardwareWatchpointsFrom(
+ static_cast<NativeRegisterContextNetBSD &>(
+ source.GetRegisterContext()));
+ if (!s.Fail()) {
----------------
labath wrote:
> I'd probably make a covariant override of `GetRegisterContext` which returns
> a `NativeRegisterContextNetBSD&`.
Thanks. I didn't know this was actually legal in C++.
================
Comment at: lldb/test/Shell/Watchpoint/netbsd-nouserdbregs.test:5
+# REQUIRES: native && system-netbsd && (target-x86 || target-x86_64) &&
!dbregs-set
+# RUN: %clang %p/Inputs/thread-dbreg.c -pthread -g -o %t.out
+# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error
false' -s %s %t.out 2>&1 | FileCheck %s
----------------
labath wrote:
> mgorny wrote:
> > Note to self: try `%clang_host` as suggested in D70050.
> So, did you try it?
Sorry, I've forgotten about it. Done now. I presume I don't need `native` in
REQUIRES now.
Will address remaining comments soonish.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70023/new/
https://reviews.llvm.org/D70023
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
