jankratochvil added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1854
+ gdd_objfile_section_list->FindSectionByType(
+ eSectionTypeELFSymbolTable, true)) {
+ SectionSP module_section_sp = unified_section_list.FindSectionByType(
----------------
I miss here comparing that the sections inside `.gnu_debugdata` file match
sections in the outer file:
```
jankratochvil: "hm.... I was under the impression that section number should
remain the same in regular and split debug files" - maybe you are right but
then we could just also compare the two section tables and if they differ then
reject whole .gnu_debugdata. And then we do not have to compare section names
but it is enough to compare section indexes.
labath: "right but then we could just also compare the two section tables and
if they differ then reject whole .gnu_debugdata."
labath: I would like that ^
```
Also I do not see here handling `.strtab`, why does it work without moving also
`.strtab`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66791/new/
https://reviews.llvm.org/D66791
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
