davide added a comment.

In D60300#1456472 <https://reviews.llvm.org/D60300#1456472>, @clayborg wrote:

> In D60300#1456468 <https://reviews.llvm.org/D60300#1456468>, @JDevlieghere 
> wrote:
>
> > In D60300#1455790 <https://reviews.llvm.org/D60300#1455790>, @davide wrote:
> >
> > > I think this is good regardless for readability, but I would really 
> > > appreciate if we can collect some numbers to see how effective this 
> > > change actually is.
> >
> >
> > I see 120 -> 12 seconds on my iMac Pro.
>
>
> Nice! Might be nice to have some automated info that gets dumped when one 
> file with multiple tests takes a long time and suggest breaking them up in 
> the python test infrastructure modules. Might be other nice gains to be had?


lit has this feature. It's called `--time-tests`. That's how we discovered the 
problem. There are other tests that we can fix.

--Davide


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60300/new/

https://reviews.llvm.org/D60300



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to