cameron314 added a comment. In D53412#1450182 <https://reviews.llvm.org/D53412#1450182>, @clayborg wrote:
> All of these are in SBProcess. No need to change everywhere else, I just see > a ton of duplicated code here in the SBProcess.cpp. If we contain those in a > small struct/class, then we can easily make changes as needed without 50 > diffs in this file each time. So no need to fix all the call sites in this > patch, just the ones in SBProcess.cpp Ah, that makes more sense :-) Sorry I misinterpreted your suggestion. I can add a RAII lock-helper struct in SBProcess, but the order that locks are taken within it must not be modified without changing *all* the functions that take both locks (both directly and indirectly), which includes a significant portion of the SB API (and not just SBProcess). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53412/new/ https://reviews.llvm.org/D53412 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
