lemo added inline comments.
================
Comment at: source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:171-174
+ // TODO: we need to compare the age, in addition to the GUID
if (expected_info->getGuid() != guid)
return nullptr;
+
----------------
labath wrote:
> Mainly out of curiosity, what's the complication here? The llvm interface
> does not provide the means to retrieve the age?
Yes, the interface doesn't expose the age, although that's not not really the
problem (the age is a detail - part of the generic "Debug ID")
We just need to make the handling of PE/COFF & VC UUIDs more consistent: right
now most places expect a stripped version (just the GUID). This is wrong since
a correct PDB match should take the age into account, but it's outside the
scope of this change.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55142/new/
https://reviews.llvm.org/D55142
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
