jingham marked an inline comment as done.
jingham added inline comments.

================
Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:104
+        if (image_infos_address != m_maybe_image_infos_address)
+          did_exec = true;
+      }
----------------
jasonmolenda wrote:
> Do you want to copy the image_infos_address value into 
> m_maybe_image_infos_address so we can detect the next exec?
You don't need to. If we've exec'ed we have to call DoInitialImageFetch again - 
since the world has changed - which resets the value.  I don't want to do it 
twice, but I can put in a comment explaining why if that would help.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55399/new/

https://reviews.llvm.org/D55399



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to