jingham marked 2 inline comments as done.
jingham added inline comments.
================
Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:83
+ m_break_id(LLDB_INVALID_BREAK_ID), m_mutex()
+ , m_maybe_image_infos_address(LLDB_INVALID_ADDRESS) {}
----------------
aprantl wrote:
> Why not just write C++11-style `= LLDB_INVALID_ADDRESS` in the declaration?
I think it's confusing to have some declaration initialization and some
constructor initialization, and I didn't want to change this class over to all
initialization as it would add noise to the patch.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55399/new/
https://reviews.llvm.org/D55399
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
