aprantl added inline comments.
================
Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:83
+ m_break_id(LLDB_INVALID_BREAK_ID), m_mutex()
+ , m_maybe_image_infos_address(LLDB_INVALID_ADDRESS) {}
----------------
Why not just write C++11-style `= LLDB_INVALID_ADDRESS` in the declaration?
================
Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:102
+ if (m_maybe_image_infos_address != LLDB_INVALID_ADDRESS) {
+ lldb::addr_t image_infos_address = m_process->GetImageInfoAddress();
+ if (image_infos_address != m_maybe_image_infos_address)
----------------
clang-format :-)
================
Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h:107
mutable std::recursive_mutex m_mutex;
+ lldb::addr_t m_maybe_image_infos_address;
----------------
Perhaps add a `///` comment explaining what is being stored here?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55399/new/
https://reviews.llvm.org/D55399
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
