aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:137
+  auto successHandler = [this] {
+    // CODETAG_DEBUG_SESSION_RUNNING_PROG_RECEIVED_SIGINT_PAUSE_PROGRAM
+    if (!CMIDriver::Instance().SetDriverStateRunningDebugging()) {
----------------
Is this a copy&paste error?


================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:142
+          MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE),
+          this->m_cmdData.strMiCmd.c_str(),
+          rErrMsg.c_str()));
----------------
Might want to factor this out into a HandleBoolReturnValue helper if it appears 
more than once.


https://reviews.llvm.org/D47992



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to