clayborg added inline comments.

================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:373-377
+  if (error.Success())
+    return MIstatus::success;
+
+  SetError(error.GetCString());
+  return MIstatus::failure;
----------------
Maybe these four lines should be put into a utility function? Something like:
```
MIstatus ReturnMIStatus(lldb::SBError &error) {
  if (error.Success())
    return MIstatus::success;

  SetError(error.GetCString());
  return MIstatus::failure;
}
```
I am sure just about every MI command will end with something like this.


https://reviews.llvm.org/D47992



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to