I put the using only if I have to type the namespace more than once. I can change the global using to be local, but I don't think it makes sense to either always put the using or never put it On Mon, Mar 6, 2017 at 3:59 AM Tamas Berghammer via Phabricator < revi...@reviews.llvm.org> wrote:
> tberghammer added a comment. > > Can you make the usage of "using namespace llvm::sys::fs;" a bit more > consistent? Sometime you write fully qualified name, sometime you add it to > the top of the file while sometime only to the function where it is used. > > > > ================ > Comment at: llvm/include/llvm/Support/FileSystem.h:482-486 > /// @brief Does status represent a directory? > /// > /// @param status A file_status previously returned from status. > /// @returns status.type() == file_type::directory_file. > +file_type get_file_type(const Twine &Path); > ---------------- > Please fix the comment > > > https://reviews.llvm.org/D30624 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
